search

MrSwitch / hello.js

A Javascript RESTFUL API library for connecting with OAuth2 services, such as Google+ API, Facebook Graph and Windows Live Connect
https://adodson.com/hello.js/
MIT License
4.63k stars 548 forks source link

Yahoo contacts #431

Open mebibou opened 8 years ago

mebibou commented 8 years ago

In the api list for Yahoo, you are not listing the me/contacts api, but when I look at the source code it seems you are actually loading the contacts through the me/friends api. Is this a mistake?

MrSwitch commented 8 years ago

Yeah it could be. The definition between the two arose when some services had two different approaches to contact management, i.e. Google has Gmail contacts and Google+ friends. I guess with Yahoo this is more like contacts. Is this a problem?

mebibou commented 8 years ago

Not a very big one but it means I can't have something generic to retrieve the contacts as in hello(service).api('me/contacts') where service is a variable.

MrSwitch commented 8 years ago

Sure, copy, paste and rename the me/friends definition in yahoo.js and create a PR. Thanks.