MrTJP / ProjectRed

Redstone Engineering
MIT License
466 stars 178 forks source link

Redstone Alloy Wires checking if wrong side of blocks can connect redstone #1693

Closed dannydjdk closed 1 year ago

dannydjdk commented 2 years ago

Describe the bug Redstone Alloy Wires will only connect to a block if the opposite side of that block can connect redstone.

To Reproduce Steps to reproduce the behavior:

  1. Place a redstone alloy wire next to a block from another mod that can connect redstone only on specific sides of the block such as Tiny Redstone's redstone panels or Redstone Pen's redstone dust.
  2. See that the alloy wire will not connect to a side unless the opposite side of that block can connect to redstone.

2021-11-05_18 54 06 2021-11-05_18 54 24 The redstone panel from Tiny Redstone reports that it can connect to redstone on any side that contains a component. Project Red's wires are consistently connecting to the sides opposite those with components.

2021-11-05_19 26 06 2021-11-05_19 26 21 Redstone Alloy is not connecting to the Redstone dust placed by Redstone Pen in the pictures above unless the opposite side is activated.

Expected behavior 2021-11-05_18 54 49 The picture above shows that vanilla redstone properly connects to a redstone panel from Tiny Redstone only on the sides with components.

I haven't check the code, but it is almost certainly the case that the wrong Direction is being passed to the canConnectRedstone method. The direction parameter expects the direction from the querying block to the block being queried, not the other way around.

Versions Include versions of the dependencies. And since you're looking at it, make sure ProjectRed is up to date. Don't submit bugs for old versions, as they could have been fixed.

Screenshots/Videos See above.

MrTJP commented 1 year ago

This was fixed at some point