search

MrTJP / ProjectRed

Redstone Engineering
MIT License
471 stars 182 forks source link

[1.18] ProjectRed conflicts on new world creation in a modpack #1792

Closed PhweeDev closed 10 months ago

PhweeDev commented 1 year ago

Describe the bug Whilst playing my modpack again, I saw Project Red had updated to 1.18.2, I added them, and worlds fail to generate due to failing to generate chunks and Feature order cycle found. I predict it's a conflict between Project Red's generation and stuff like TerraBlender and BYG, however I couldn't replicate on these mods' own.

Expected behavior Loads into a world eventually instead of crashing once it starts to generate.

Crash Log https://paste.gg/p/anonymous/b313c4e9583e4337834822f2b128287e (Latest log is too large, will have to attach if you need it)

Versions ProjectRed Versions: 4.16.0-beta-14 for all ProjectRed mods CBMultipart Versions: 3.1.0.137

2023-07-10-7.log

Hopefully you're able to deduce something, I can't really figure out what or if anything else is causing the issue. Since it's only when ProjectRed is in the pack. otherwise, it works fine.

jdawg3636 commented 1 year ago

I was able to isolate this down to a conflict with Occultism, which OP's crash log shows was installed.

The conflict appears to be specific to the "Project Red - Exploration" module. I haven't dug in too deep yet, but by using a modified version of cyanide I was able to see that the feature cycle in my specific case was triggered by silver ore generation. It is possible/likely that other ores/features have the same issue.

Steps to reproduce: 1) Attempt to create a world with the following seed (it probably crashes for many/all seeds, but I've confirmed on this one): -8514774603063900555

Mods/versions installed:

KeenbeanDev commented 11 months ago

Confirming it appears to be Silver Ore that causes this; Using a separate pack with all ProjectRed modules and Occultism installed, feature order cycles were present [Cyanide did not outright state this in my logs]; Toggling Silver Ore off in the ProjectRed config appears to have remedied this conflict and allowed world generation again. It appears that other Silver Ore blocks added by additional mods does not trigger this conflict.

MrTJP commented 10 months ago

Addressed in af29c025fc185fe2e12809c8cb67c14fc9856cc2. Was accidentally registering all ProjectRed ores without the projectred_exploration namespace. This caused, in this case, Silver ore to be registered as minecraft:silver_ore. Another mod is likely doing the same thing, causing the conflict.