search

MrTJP / ProjectRed

Redstone Engineering
MIT License
474 stars 184 forks source link

Botania Structure Visualisation breaks with ProjectRed Core installed #1807

Closed KeenbeanDev closed 12 months ago

KeenbeanDev commented 1 year ago

Description: When running both Botania and ProjectRed Core, the rendering for Botania seems to be completely mismatched to expected behaviour. Where the hologram structure follows the user around to place down, ProjectRed will cause it to gravitate around XYZ 0,0,0, and halve the size of the structure itself. Testing alone with the CB Multipart dependency and ProjectRed disabled, expected behaviour returns to normal. image Image demonstrates the "Ritual of Gaia" structure, with block size halved (comparing iron blocks to amethyst block), locked in place halfway between surface and Y0.

To Reproduce

  1. Install ProjectRed Core and Botania (versions noted below)
  2. Generate any world and launch it
  3. Spawn in a 'Lexica Botania' book, go to the 'Entry Index' page (green book icon), and type 'Gaia' to search for the 'Ritual of Gaia' entry.
  4. Click 'Next Page', and where it shows the structure, click the eye icon named 'Visualize' (image below)
  5. Look towards X0 Y0 Z0 until you locate the structure. It will move around trying to centralise around these coordinates, and be halved in size. image

Expected behavior When visualising the structure, it should hover just above the players cursor, following mouse movement without trying to follow X0 Y0 Z0 (example below) image

Versions

KeenbeanDev commented 1 year ago

Update with this: The bug appears to extend to other guidebooks provided by Patchouli. This mod also translates into mods like Blood Magic, Ars Nouveau and more.

However, I have noted that one particular structure provided by Occultism, the 'Aviar's Circle' ritual structure, is not affected. This structure contains only non-solid blocks, something that differs from all other structures involved (Blood Magic Rune Blocks, Botania Beacon & Material Blocks, etc). So, I think the problem lies in how solid blocks are handled.

Patchouli is also developed by Vazkii, the developer for Botania, so this should extend the logic of the original Botania issue reported.

Patchouli Version: 1.18.2-71.1

MrTJP commented 1 year ago

Thanks for the details. Will take a look soon. What graphics mode are you running? Did you try changing between Fabulous and the older modes?

KeenbeanDev commented 1 year ago

Hi! I believe I was using Fancy mode during the testing. Truthfully, I did not know Fabulous graphics even existed in Minecraft until reading your response!

I have just re-tested this bug with both Botania and Patchouli on the various graphics modes. It appears that, when in Fabulous mode, the issues are not present and all functionality is restored. Both Fast and Fancy graphics will continue to display the issues originally mentioned. So I'm inclined to believe this may be the root cause of the problem.

MrTJP commented 12 months ago

I was completely unable to reproduce this. But I did find the bug using your description alone. I'm 99% sure it will fix the problem: baaeb00b2dc06d6ac47aa45f66158509b8cd80e9