MrTJP / ProjectRed

Redstone Engineering
MIT License
474 stars 184 forks source link

[Bug] Dupe bug when using FTBUltimine on 2 or more lights that use CBMultipart #1837

Open sprocketaudio opened 8 months ago

sprocketaudio commented 8 months ago

Minecraft version

1.19.x

CodeChickenLib version

1.19.2-4.3.2.490-universal

CBMultipart version

1.19.2-3.2.0.139-universal

ProjectRed version

1.19.2-4.17.0-beta+8-illumination

What happened?

Place 2 or more lights that use CB Multipart, then use FTB ultimine to mine them and they will duplicate

Crash log

no crash

How do you make it happen again?

As above

MrTJP commented 8 months ago

My guess is Ultimine is also breaking the block the lights are attached to, causing them to self-drop, and then again re-mining the lights before they are actually removed from the world.

Does this happen with other parts that drop themselves when the block they are sitting on is broken? (Wires, gates, torches, etc)

Please provide a screenshot of the group of blocks you are breaking that causes this.

sprocketaudio commented 8 months ago

I tested putting 2 Minecraft torches on 2 blocks that were connected, then vein mined the block and only got 2 torches back so no it doesnt.

Here is a screenshot of the lights I was mining (I am vein mining those ;lights directly no the block under them) and the resulting 3 in my inv

image image

MrTJP commented 1 week ago

Based on the investigation in #1900, we know this is not caused by block drops. Most likely some harvesting logic issue