search

MrTJP / ProjectRed

Redstone Engineering
MIT License
473 stars 183 forks source link

ProjectRed Compat .jar is bundled with a version of the ComputerCraft API #652

Closed ghost closed 9 years ago

ghost commented 9 years ago

As of version 4.5.6, build 57, the ProjectRedCompat jar includes a version -- an outdated version -- of the ComputerCraft API. This interferes with the real version of the API, as included in the ComputerCraft 1.65 jar, and causes crashes in conjunction with mods that depend on that API, like OpenPeripherals.

Original bug report on OpenPeripherals issue tracker: https://github.com/OpenMods/OpenPeripheral/issues/206

MrTJP commented 9 years ago

Fixed via 01138b14523b5bee2b114dec5115dc188892ff09. Will have an immediate build for this.

theoriginalbit commented 9 years ago

You're still bundling the ComputerCraft API. While updating the API to the latest does fix the issue at hand, it is still not ideal, you should not bundle APIs in your packages.

We have the dependencies in @Mod and the @Optional interface for a reason.

dan200 commented 9 years ago

Project:Red 4.5.12.64 still includes the ComputerCraft API.

MrTJP commented 9 years ago

I've actually spent several hours digging though logs and such, but I can't find why. If I don't include them, I get crashes despite the use of @optional annotations.