search

MrTJP / ProjectRed

Redstone Engineering
MIT License
467 stars 179 forks source link

Incomplete Volcano Worldgen #738

Closed Carbon-Key closed 9 years ago

Carbon-Key commented 9 years ago

Hello,

No crash here, just some weirdly formed volcanoes that happen quite often and don't look so hot. I'll include screenshots of what I mean down below. I am running build 4.5.14 #66 of Project Red and 1.0.5.11 of of the core. As per Player from the IC2 team's instructions I am also obligated to mention that I am running FastCraft version 1.19. A full modlist can be found at http://pastebin.com/igU63Sjy. It is also worth mentioning that this issue started as early as 4.5.12 build #64 for me.

Here are two screenshots of an affected volcano, one with chunk boundaries highlighted and one without: 2015-03-08_16 05 39 2015-03-08_16 05 50

Let me know if you'd like any additional information on my end and I hope to hear from you soon. Keep up the good work!

Serejai2 commented 9 years ago

Same issue here. Happens without any other mods running, using the latest version of Forge and PR #66. Regenerating the chunks does not help.

Most volcanoes appear to have one good side and three sides that fail to generate.

BionicFelps commented 9 years ago

I've seen this as well, not sure if it's related, but I've also seen trees generated on top of the volcanoes. The first log is missing, but the rest of the tree is still there. (so there's a 1 block space between the bottom log and the volcano). Happens with both vanilla trees and mod trees. Only seems to happen when the generated volcano is VERY shallow, basically mirroring what the normal terrain might have looked like...

After going back and looking... It's happened only with Dark Oak trees (roofed forest biome)

Just got one with Jungle Trees, but I suspect that was ExtraBiomesXL shenanigans as it was a BiomesXL biome, and a special version of jungle trees.

MrTJP commented 9 years ago

Volcanoes fail to generate when the chunk literally doesn't exist yet, which is why there are entire sections just missing. It would be difficult to check all chunks before starting generation, because the size of the volcano is determined during generation. Hard fix...

praecipitator commented 9 years ago

Have that issue, too. Would some kind of check on chunk generation be possible, like, "if currently generating chunk is next to a volcano, run that part of volcano generation again, with the same seed"? Whenever a volcano generates, it could save a list of chunks it should generate on, to make this easier

lilrichy commented 9 years ago

Same problem on the server I am running. I have flown around a lot and have not seen any properly formed volcanos. These used to work just fine and were a great addition to the world. Now they are ugly flat sections of basalt with 1 lava source in the center.

MrTJP commented 9 years ago

Was fixed in latest MrTJPCore.