search

MrTanoshii / rusty-autoclicker

A pure Rust portable auto clicker built for Linux, macOS & Windows.
Creative Commons Zero v1.0 Universal
71 stars 12 forks source link

Add Icon to Windows binary #25

Closed nozwock closed 1 year ago

nozwock commented 1 year ago

Addressing #9 by implementing solution #1

nozwock commented 1 year ago

Currently using icon-64x64.ico for Icon resource.

Screenshot

nozwock commented 1 year ago

Btw should I merge these few refactors aswell or create a separate PR for it instead?

MrTanoshii commented 1 year ago

Btw should I merge these few refactors aswell or create a separate PR for it instead?

Separate PR please

MrTanoshii commented 1 year ago

@MrTanoshii Test fails because lib doesn't exist anymore, here

https://github.com/MrTanoshii/rusty-autoclicker/blob/45961c9ead705fb5d367171d06a746f55e7cbb28/.github/workflows/rust_check.yml#L92

Should I make changes to the Rust check workflow?

Sure, we can actually get rid of the whole job in a new PR. https://github.com/MrTanoshii/rusty-autoclicker/blob/45961c9ead705fb5d367171d06a746f55e7cbb28/.github/workflows/rust_check.yml#L73-L92