search

MrTanoshii / rusty-autoclicker

A pure Rust portable auto clicker built for Linux, macOS & Windows.
Creative Commons Zero v1.0 Universal
71 stars 12 forks source link

refactor: improve load_icon() fn API #33

Closed nozwock closed 1 year ago

nozwock commented 1 year ago

Expands upon #32 Issue: #31

Lmao @MrTanoshii, I had also worked on a solution :rofl:

MrTanoshii commented 1 year ago

Oh man, my bad I'll close this but thanks anyway

Linking #32 , might prove useful in the future

nozwock commented 1 year ago

Did you take a look at the changes? Anyways, I've got to go, see you later

MrTanoshii commented 1 year ago

Yup, looks good to me.

I prefer my approach for the image loading but noted that I should have put the hardcoded path in defines.rs I'm also heading off now, I'll make a PR to fix that tomorrow unless you're faster ;P

nozwock commented 1 year ago

but noted that I should have put the hardcoded path in defines.rs I'm also heading off now, I'll make a PR to fix that tomorrow unless you're faster ;P

??, Isn't that what this PR was? The only other extra stuff I've done is error handling and function name change.

Oh and also that the fn takes a u8 slice, which makes the fn reusable imo.