search

MrToph / react-native-progress-circle

A light-weight progress circle indicator for React Native.
MIT License
190 stars 83 forks source link

Fix overflowing halfCircleRender on IOS devices #18

Closed darekg11 closed 5 years ago

darekg11 commented 5 years ago

Hi, my Pull Request for HacktoberFest : ) Back story: I really needed a Circle Progress component for React-Native and I really liked this one, as this one is not depending on any other 3rd libraries like react-native-svg. So I went ahead and installed that, imported and was happyfully using that Component for couple of days until I tried my app on IOS based devices.

My Environment: React Native: 0.57 Android Device: Huawei P8 Lite, Android 6.0 IOS Device: Emulator IOS / IPhone 6S IOS: 11.4 This is how it was looking (example from README) on Android - totally fine:
obraz

And this is how the same code was looking on IOS Device:
simulator screen shot - iphone 6s - 2018-10-27 at 15 52 41

The fix is simply to hide overflow on halfCircles, inspired by this issue:
https://github.com/facebook/react-native/issues/13760

After applying the fix, this is how the same view looks on Android (exactly the same, as this is only broken on IOS):
obraz

And IOS device:
simulator screen shot - iphone 6s - 2018-10-27 at 15 57 05

Let me know if you have any questions or anything should be changed.

MrToph commented 5 years ago

Hi, thanks a lot for the PR. The new images look good, I don't have an iOS device to test this on, but I'll trust you on this :)

This shouldn't break anything, I'll release this as a patch.

darekg11 commented 5 years ago

Thanks :+1: Now I can happily use new version, yay