search

MrToph / react-native-progress-circle

A light-weight progress circle indicator for React Native.
MIT License
191 stars 83 forks source link

Is it compatible with react-native v0.57.4? #19

Closed varqasim closed 6 years ago

varqasim commented 6 years ago

I'm in process of upgrading my app which is using react-native-progress-circle v2.0.1, will it be compatible if I upgrade the react-native version to 5.7?

MrToph commented 6 years ago

I guess so, it's just JavaScript and unless they heavily reworked the yoga layout engine, I don't see why not.

Just try it.

jonathangreco commented 6 years ago

Hi @MrToph. Actually, not so much. There is a small graphical bug with the latest version. The progress circle is not a circle anymore, it seems that it's a rectangle or something similar.

If you can test it to confirm, I'll appreciate...

In fact the shape I've got with 0.57.4 was exactly this one : https://github.com/MrToph/react-native-progress-circle/issues/3

So when reverted to 0.57.1 all back to normal.

Tested on IOS 12.1 and IOS 12. It seems that does work with Android.

limaAniceto commented 6 years ago

React Native 0.57.4 and the issue still happens

halaharr commented 5 years ago

Is this issues resolved. I am having issues with 0.59.8?