search

MrToph / react-native-progress-circle

A light-weight progress circle indicator for React Native.
MIT License
191 stars 83 forks source link

fix half circle clipping issues on iOS and android #6

Closed huangmr closed 6 years ago

huangmr commented 7 years ago

some clipping issues on iOS and android are now fix:

screen shot 2017-09-07 at 08 36 15 screen shot 2017-09-07 at 08 36 30
MrToph commented 7 years ago

Hi, thanks for the PR. I don't get these clipping issues. On what devices did they happen? And the percentage circles for 5 and 7 seem completely off in your first pictures - this doesn't happen to me (tested only on Android). I'm really curious.

Also I don't understand how your changes would fix them, however you're right I can just set the left property to 0 both times in renderHalfCircle, makes it easier. :+1:

adityak16 commented 6 years ago

Hi, @huangmr @MrToph I am still getting this issue when the percent is less than 50 on Android. Otherwise it perfectly running on iOS.

React-native : 0.48.4

This example is with 30 % :

progress_circle