MrTroot / autofish

A Minecraft Autofish mod for the Fabric and Forge mod loaders.
GNU General Public License v3.0
57 stars 52 forks source link

aquaculture 2 #10

Closed foggirya000 closed 2 years ago

foggirya000 commented 3 years ago

Does not work with modded rods, just vanilla.

aalexx-S commented 2 years ago

Yeah, I'm having the same issue on 1.16. It looks like the only thing that may cause the issue is isHoldingFishingRod() check, but the source code clearly shows that it is a type of net.minecraft.item.FishingRodItem.

aalexx-S commented 2 years ago

After some experimenting, I found out that it is a catch detection issue. After forcing multiplayer detection, it works perfectly. @MrTroot Can you update the documentation to inform users to try out force multiplayer detection if it's not workign with modded rods.

MrTroot commented 2 years ago

The multiplayer detection setting is the current workaround to get this working with modded rods. I believe newer versions signify that the checkbox is intended for mod compatibility.