search

MrTroot / autofish

A Minecraft Autofish mod for the Fabric and Forge mod loaders.
GNU General Public License v3.0
57 stars 52 forks source link

Support Minecraft Java Edition 1.19 #26

Closed 7coil closed 2 years ago

7coil commented 2 years ago

It's me again... again!

This PR bumps dependencies to their latest versions, and additionally uses the TerraformersMC maven repositories instead of Curseforge.

NB. Other than basic singleplayer autofishing (with a single rod), no other feature has been tested. Multiplayer and Singleplayer autofishing seem to work fine. This is just an update to make the existing mod functional with the latest and greatest update.

EDIT: Unofficial builds now available @ https://github.com/7coil/autofish/releases/tag/1.19-fabric

7coil commented 2 years ago

For your sanity, I recommend squashing these commits because there's some past commits in the pile for some reason...

PRRB commented 2 years ago

Minecrash is crashing while autofishing with the snapshot build you posted above @7coil

It's quite intermittent e.g. fish for 10-30 mins, minecraft randomly crashes.

Sorry I don't have the crash report here, I'll post it if I get it again. The log for sure had a reference to autofish at the top of the callstack though. It's a single-player only installation.

7coil commented 2 years ago

Sounds like a pickle!

I'll see if I can reproduce the error, but the callstack would totally be helpful.

PRRB commented 2 years ago

crash-2022-06-18_16.17.00-server.txt crash-2022-06-18_17.57.44-server.txt crash-2022-06-19_14.37.29-server.txt Here you go! Didn't realize the crash dumps are saved in game dir automatically.

7coil commented 2 years ago

Eek!

Sounds like something to look for then. Thanks for the help.

7coil commented 2 years ago

I haven't been able to reproduce the bug yet, even after an hour. Does the bug still exist when you only have the mod installed by itself?

7coil commented 2 years ago

Sounds like it's still a thing; Keep following on #33