MrTroot / autofish

A Minecraft Autofish mod for the Fabric and Forge mod loaders.
GNU General Public License v3.0
57 stars 52 forks source link

Update for 1.19.3. Fix mixin and references due to PlaySoundIdS2CPack… #40

Closed DrakoTrogdor closed 1 year ago

DrakoTrogdor commented 1 year ago

Updated gradle.properties and build.gradle for latest 1.19.3 dependencies. Removed references to PlaySoundIdS2CPacket due to removal from yarn 1.19.3+build.3 (removed since 1.19.3-rc3+build.1) src/main/java/troy/autofish/mixin/MixinClientPlayNetworkHandler.java -> @Inject(method = "onPlaySoundId"... src/main/java/troy/autofish/monitor/FishMonitorMPSound.java -> public void handlePacket Bump version patch number from 0.9.5 -> 0.9.7 (Was using 0.9.6 for 1.19 builds)

PRRB commented 1 year ago

Works for me on 1.19.3 - thanks!

SamCyanide commented 1 year ago

Works on my machine 👍

Avasty commented 1 year ago

Awesome! I have tested on 1.19.3 on my local PC and it worked perfectly.

Here are the files I have compiled & tested: https://drive.liblaf.top/github/autofish/.

Can you please upload it again? Cannot get that to work... Thanks ;)

IF-desu commented 1 year ago

The Download link was 404,plz upload the file again

PRRB commented 1 year ago

Here you go: https://easyupload.io/ld8qp7

dubfib commented 1 year ago

Here you go: https://easyupload.io/ld8qp7

That download link seems kinda sketch, never heard of that service before. I'll link the download below through github, and its a .zip file with the mod jar inside of it because github doesn't support that file type. I'll also include the virustotal analysis if you would like to see it. https://github.com/MrTroot/autofish/files/10531347/autofish-0.9.8-SNAPSHOT.zip https://www.virustotal.com/gui/file/88fe6af9dff36b3db22d9ee947e95755f699930afabbd27f6421caa5bc1e1c76?nocache=1