MrUniverse44 / OmegaPixelMOTD

Motd plugin for Spigot, Velocity, Bungee, Sponge
37 stars 5 forks source link

Fix incorrect access control logic #19

Closed TTtie closed 2 years ago

TTtie commented 2 years ago

This pull request patches the incorrect access control logic enforced in the connection/server switch listeners.

Currently, the code denies access "if player is not in username whitelist or if player is not in UUID whitelist", where the intent seems to be to deny access if the player is in neither of those lists.

Unfortunately, the same check is also applied to blacklisting, where the code denies access "if player is not in username blacklist or if player is not in UUID blacklist", where the intent seems to be to deny access if the player is in either of those lists.

MrUniverse44 commented 2 years ago

Actually, It was my bad, thx for fix that