Fix deprecated .data property paths

MrVauxs / pf2e-jb2a-macros

Discord: @vauxs

GNU General Public License v3.0

11 stars 27 forks source link

Fix deprecated .data property paths #196

Closed oWave closed 2 months ago

oWave commented 2 months ago

Left unchanged:
- Acid Flask is unused? The feat lookup part needs warpgate anyway
- Cone Template is unused
- Dimension Jumps needs warpgate

I have no idea what token.document.data.scale used to be, it no longer exists. But using width/height instead doesn't work. The Encumbered effect looks like it used to without multipliers, and scaleToObject without passing extra scale on those effects looks good as well.

MrVauxs commented 2 months ago

The token.document.data.scale is now token.document.texture.scaleX/scaleY. Just replace it with scaleX as the two are practically never out of sync.

oWave commented 2 months ago

Sequencer already uses scaleX/scaleY with considerTokenScale: https://github.com/fantasycalendar/FoundryVTT-Sequencer/blob/a3edc36bc6a8756b9fe180f3ab4f9e7495444be5/src/canvas-effects/canvas-effect.js#L2655

MrVauxs commented 2 months ago

Yep, just not with animateProperty I believe.