MrVauxs / vauxs-archives

Discord: @vauxs
MIT License
3 stars 0 forks source link

Missing CSS variables #7

Closed morepurplemorebetter closed 5 months ago

morepurplemorebetter commented 5 months ago

Thank you very much for fixing bug #6 so quickly! I'm writing this issue because of the second part of that bug, which I totally understand if it was overlooked.

Looking at the CSS of the headers of the Vauxs' Archives windows (because they have too little padding compared to those of other windows), I see that there are references to CSS variables that don't seem to be set:

image

As a result of the fallback for the padding being different than FoundryVTT's default setting, the button to close windows made by this module look off (see the screenshot in issue #6).

I don't know what those variables are supposed to do, but I would fix this by changing the padding to padding-left so that at least the top-right buttons don't render differently.

MrVauxs commented 5 months ago

I cant say I can replicate this, let alone your styling. chrome_pfAeyv2Zk0

I need to know the Foundry and system version you are playing on.

morepurplemorebetter commented 5 months ago

Apologies, I didn't realise that the window styling I was seeing wasn't the FoundryVTT standard. The alternative styling appears to be the result of another module. There is still a 4px padding difference between the default and your module, but that is almost impossible to notice. I'll add some custom CSS to fix the padding.

Do you also not see the missing CSS variables? They probably aren't a big deal, and don't need to be fixed because the fallback values are there.

I see them on a test world, which has only 1 active module. Test world stats:

MrVauxs commented 5 months ago

I have added the variables needed to make it pixel accurate to Foundry defaults.

I cannot promise compatibility with other modules modifying the UI.

chrome_hxyY9aIwbS

morepurplemorebetter commented 5 months ago

Thank you very much!