search

MrViolets / Deep-Tab-Search

Chrome extension that lets you search the content of all your open tabs.
https://chromewebstore.google.com/detail/dbppkkjmaloclihjakcpnionomlidbhk
GNU General Public License v3.0
123 stars 7 forks source link

[Bug report] Incompatible with "Sleeping tabs" of Edge #9

Open Atlantis-Gura opened 5 months ago

Atlantis-Gura commented 5 months ago

Edge Version: 121.0.2277.98 (stable) (64x)

Current Behavior: When Edge's Sleeping tabs feature is turned on, if none of the tabs are slept, then everything works fine. Once a tab is slept on, the extention can display all open tabs, but when I enter the search content, the extention does not respond. Then I activate all the slept-on tabs again, and the extention will work again.

Expected behavior: Edge's Sleeping tabs feature doesn't affect plugin functionality.

p.s. You've made a cool and very useful browser extension, thank you!

zolrath commented 3 months ago

In an extremely cursory look, it seems like the extension trying to inject content.js into the sleeping tabs which fails, causing the plugin to remains stuck with indexing = true.

Looking at the promises generated in the injectScriptsIfNeeded function in inject.js, all of the promises for the unslept tabs resolve quickly while every slept tab remains for all of time.

image

MrViolets commented 3 months ago

Thanks to you both. I did take a look into this briefly and it looks like there's no way to skip sleeping tabs on Edge since it's a unique state that's not exposed to installed extensions. The code that @zolrath is referring to is responsible for loading the content within Chrome's discarded tabs before performing a search and I think for now I'd prefer to optimize for Chrome.