MrYsLab / FirmataExpress

An enhanced version of StandardFirmata to be used with pymata-express
GNU Affero General Public License v3.0
37 stars 15 forks source link

Robo HAT MM1 / Firmata Express Firmware - no Ultrasonic.h #9

Closed wallarug closed 4 years ago

wallarug commented 4 years ago

Hi @MrYsLab ,

Trying to compile the FirmataExpress for Robo HAT MM1 and hit an issue.

FirmataExpress:41:10: fatal error: Ultrasonic.h: No such file or directory

 #include <Ultrasonic.h>

          ^~~~~~~~~~~~~~

compilation terminated.

exit status 1
Ultrasonic.h: No such file or directory
wallarug commented 4 years ago

I presume it is this library missing: https://github.com/ErickSimoes/Ultrasonic

Might need to either include it in the release or at least say it is a dependency with instructions on how to install it.

MrYsLab commented 4 years ago

This is documented here https://mryslab.github.io/pymata_rh/firmata_express/. Item #4 addresses this.

wallarug commented 4 years ago

Ahh, I see this now. Thank you!

MrYsLab commented 4 years ago

It looks like the Arduino IDE now will accept dependencies and will suggest installing them when installing the host library. I will update Firmata-Express to take advantage of this relatively new feature. I will be working on a problem reported for the STM32 and am waiting for an STM32 board to arrive. If any changes are required for the STM32, I will incorporate the dependency then. If no changes are necessary, I will generate a new release with the dependency. Long story short, it will probably be about a week before I incorporate the dependency change.

MrYsLab commented 4 years ago

The Arduino now prompts the user to install Ultrasonic.

wallarug commented 4 years ago

Thanks Alan!