search

MrYsLab / pymata-aio

This is the second generation PyMata client.
https://github.com/MrYsLab/pymata-aio/wiki
GNU Affero General Public License v3.0
155 stars 51 forks source link

INPUT_PULLUP mode clashes with SONAR #70

Closed toxuin closed 6 years ago

toxuin commented 6 years ago

I may be missing something here, but looking at Arduino's Firmata library, flag 0x0b is pin mode INPUT_PULLUP. In this library, however, it is reserved for SONAR.

In my code I was able configure pin correctly just by using 0x0b, but such discrepancy is confusing.

Source: Arduino Firmata library constants

MrYsLab commented 6 years ago

@toxuin Thanks for letting me know about this. I am surprised that no one (including me) found this before. I'm working on a fix, but it requires a lot of testing (FirmataPlus and all of its flavors, and compatibility with PyMata). As soon as it is ready, I will add a comment here.

MrYsLab commented 6 years ago

Version 2.22 should fix the problem. Please let me know if you have any further issues or questions.

toxuin commented 6 years ago

Hey, thanks for such quick response & release!