pls bump up PyMata3(arduino_wait=xxx) default value from 2 to >=3

MrYsLab / pymata-aio

This is the second generation PyMata client.

https://github.com/MrYsLab/pymata-aio/wiki

GNU Affero General Public License v3.0

155 stars 51 forks source link

pls bump up PyMata3(arduino_wait=xxx) default value from 2 to >=3 #84

Closed ericwertz closed 5 years ago

ericwertz commented 5 years ago

About 40% of our Windows user base is getting crashes (line 302@pymata_core.c where firmware_version is trying to be printed out after being concatenated onto an info string) yielding "NameError: must be str, not NoneType)".

We've found that by overriding the default delay time of two seconds (for the Uno-flavored Arduinos) all of our users can get through this rough spot. If the default were changed for "arduino_wait" from 2 to at least 3, this could help lots of WIndows users.

thanks!

MrYsLab commented 5 years ago

No problem. I will also address issues #81 and #83. As soon as I have tested, bumped the revision and placed it on pypi, I will let you know here and close out the issues.

MrYsLab commented 5 years ago

Eric, you are good to go. I appreciate your efforts in helping to resolve the issues. Resolved with release v 2.26