search

MrYsLab / pymata4

A High Performance Python Client For Arduino Firmata
GNU Affero General Public License v3.0
76 stars 30 forks source link

fix crack on shutdown #28

Closed gastonfeng closed 3 years ago

MrYsLab commented 3 years ago

Thanks for the pull request, but I am not sure what problem this fixes. Could you please provide a description of the problem? Thanks.

MrYsLab commented 3 years ago

I still don't understand what the problem is that this pull request solves. Could you please provide an example that demonstrates the issue?

MrYsLab commented 3 years ago

I am closing this pull request since I do not know what the actual problem is or how to recreate it. If you wish to proceed with this PR, please provide a detailed description of the problem and a sample program to recreate it. Thanks.

gastonfeng commented 3 years ago

send_reset after shutdown , so crack. i moved shutdown to after send_reset.

martynwheeler commented 3 years ago

What do you mean by crack? You need to provide more details of the problem and what your fix is doing. Please explain the changes you are proposing to the code and how they address the problem that you have encountered.

Thanks

MrYsLab commented 3 years ago

@gastonfeng Please provide a brief python script that demonstrates the issue you are seeing. I need to be able to understand the problem before considering any changes to the code. Thanks.