search

MrYsLab / s3-extend

Control an Arduino Uno, Circuit Playground Express, Raspberry Pi Pico, ESP-8266, ESP-32, Picoboard, Robohat MM1, or Rasberry Pi From Scratch 3
GNU Affero General Public License v3.0
27 stars 13 forks source link

Start s3a killing pending running instances of Py #16

Closed HackEduca closed 4 years ago

HackEduca commented 4 years ago

Killing pending running instances of Python.exe, during s3a start, caused by closing cmd window hitting Ctrl+F4 or X instead of Ctrl+C.

HackEduca commented 4 years ago

Thinking better you are right and make sense... So far I am testing s3a without any other python program together I did not cover more...

Thanks and sorry!!

Em seg., 6 de jan. de 2020 às 22:14, Alan Yorinks notifications@github.com escreveu:

@MrYsLab commented on this pull request.

If I understand the code, it may introduce some unintended issues. If a user has any other python programs running, it will kill them. And there is one scenario when running 2 extensions simultaneously https://mryslab.github.io/s3-extend/#multi/, this would be a problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MrYsLab/s3-extend/pull/16?email_source=notifications&email_token=AKUSNXKUUTN7HHEM4QG3XMLQ4PJNRA5CNFSM4KDLJIU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQ2ICZQ#pullrequestreview-338985318, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKUSNXOLP6ZOP4KN7XW7J4DQ4PJNRANCNFSM4KDLJIUQ .

MrYsLab commented 4 years ago

No apologies necessary.