Mrbt0907 / Weather2-Remastered

The decent update of the Weather2 mod by Corosus
33 stars 7 forks source link

1.12.2 - Rain and weather sounds don't work. #190

Closed vainlaind4in closed 1 month ago

vainlaind4in commented 2 months ago

Simply put, there is no rain and there are no sounds coming from the tornadoes or even the rain at all. I'm not totally sure if this is the case, but it could be CubicChunks or Terrarium that might be messing with it.

Steps to reproduce the behavior:

  1. Have the mods I have and load into a world
  2. Spawn rain or tornado
  3. No sound or rain (there are still lightning sounds)

Here's a screenshot: image As you can see, there's no rain occuring at all. Rain doesn't even appear in rainstorms. I have all the effects set to max, and I tried playing around with enabling vanilla rain and the rain overrides and such, but to no avail.

Here's the log: https://gist.github.com/vainlaind4in/7770723073c0d558c15591a1d3175cca It's a mess, but to give you a little info so you don't need to dig too much; the "scene enhancer" feature becomes disabled when I load into any world. I'm not totally sure what this is, but it might connect to the missing of sounds and rain.

Mrbt0907 commented 2 months ago

It looks like the crash detection system is working as intended. There appears to be a compatibility issue with one of those mods. My mod tries to look for a block, but for some reason the method used to get the block for each particle returns empty. With vanilla minecraft, it would at least return air.

I'll try to fix this with a temporary fix by assuming empty blocks are air blocks next patch. I would uninstall one of those to see which one causes the conflict.

vainlaind4in commented 2 months ago

Just tested it, CubicChunks is the culprit. Removed it and made a new world without it, and the rain and sounds work.

vainlaind4in commented 1 month ago

I am still looking forward to a fix of this bug.

Mrbt0907 commented 1 month ago

The fix is coming in the next 2.9 update.

vainlaind4in commented 3 weeks ago

I will be using the previous alpha version of the mod in the mean time, as rain and sounds work fine on there.

Mrbt0907 commented 3 weeks ago

That's your best bet as I didn't change the scene enhancer that update.