Mrbt0907 / Weather2-Remastered

The decent update of the Weather2 mod by Corosus
33 stars 7 forks source link

1.12.2 - SEUS Renewed (and maybe other shaders) compatibility should be improved #208

Open donelofficial opened 3 months ago

donelofficial commented 3 months ago

When playing with this mod (Weather2Remastered-1.12.2-2.8.11) and shaders (SEUS-Renewed-v1.0.1) I noticed a number of problems that slightly spoil the impression of the mod

Steps to reproduce the behavior: just enter the world and start playing

1. Strange texture of clouds 2024-07-15_13 54 44 2024-07-15_13 58 25 2. Skybox doesn't darken during rain, which looks really bad (even compared to the vanilla game where it at least works). How can the sun even shine through the clouds during a storm? It would be nice to have an option in settings that would switch the mod to use prettier clouds and weather effects from the shader (if at all possible) 2024-07-15_13 54 48 3. Wetting surfaces from the shader doesn't work during rain. Apparently this is because the mod uses non-standard variables for the current weather state, which the shader can't read. It would be nice to fix this if possible 2024-07-15_13 58 07

donelofficial commented 3 months ago

I also just tested the mod working with other shaders SEUS v11.0 has all the same bugs, even taking into account that there is no prefix (-) in the compatibility option (SEUS) BSL v8.2.09 displays the clouds from the mod better, but they still don't match well with the shader clouds. Also, point 2 and 3 changing shaders doesn't fix it

ProfessorFartsalot commented 3 months ago

Please join the discord and try the latest indev build. 2.8.11 is fairly outdated and I've since changed sky darkness behavior and particles substantially.

ProfessorFartsalot commented 3 months ago

https://discord.gg/K5H4Xu3vWY

donelofficial commented 3 months ago

https://discord.gg/K5H4Xu3vWY

So, I seem to have downloaded the latest version of the mod (Weather2Remastered-1.12.2-2.8.17) from the discord server, but nothing has changed dramatically. Here's what it looks like with SEUS shaders

SEUS Renewed v1.0.1: 2024-07-15_16 59 36 SEUS v11.0: 2024-07-15_17 00 56 2024-07-15_17 02 28

As you can see, the clouds from the mod still look bad, the skybox doesn't darken and wetting shader surfaces doesn't work. Maybe I'm doing something wrong?

Mrbt0907 commented 3 months ago

That shouldn't be happening as I thought I set the correct weather states on the client to allow for storms to interact with shaders. It appears to not work with SEUS specifically. I'll have to look into that when I get the chance.

As for how the particles render, I don't actually know how rendering works. To accomplish partial shader compatibility, the profiles simply modify the mod's rendering settings to best work with the shaders you decide to use. SEUS doesn't work well with weather2 and pretty much any other particles. That's something I cannot fix on my end.

donelofficial commented 3 months ago

That shouldn't be happening as I thought I set the correct weather states on the client to allow for storms to interact with shaders. It appears to not work with SEUS specifically. I'll have to look into that when I get the chance.

As for how the particles render, I don't actually know how rendering works. To accomplish partial shader compatibility, the profiles simply modify the mod's rendering settings to best work with the shaders you decide to use. SEUS doesn't work well with weather2 and pretty much any other particles. That's something I cannot fix on my end.

So, I tried many shaders, and in the end the only working ones were Complementary Shaders v4.7.2. They don't have the bugs I listed. Not my favorite shaders, but they work with this mod. Maybe in the future you should make a list of shaders on Github and CurseForge that are fully compatible with the mod, so that users don't have to search for them on their own.

Mrbt0907 commented 3 months ago

https://github.com/Mrbt0907/Weather2-Remastered/wiki/EZ-Gui---2.8#shader-compatability-mode That has been covered already

donelofficial commented 3 months ago

https://github.com/Mrbt0907/Weather2-Remastered/wiki/EZ-Gui---2.8#shader-compatability-mode That has been covered already

Oh, I didn't know there was a wiki. Thank you.