Spawner doesn't break if it spawns non-living entity like fireworks or arrows

HerobrineXia commented 3 years ago

General Info

[x] I am running a modpack
[x] I can reproduce this issue consistently
- [x] In single player
- [x] In multiplayer
[x] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I'm having the same problem.
[ ] I am crashing and can provide my crash report(s)
[x] I am using the latest version of the mod

Client Info

Minecraft Version: 1.16.5
Forge Version: 1.16.5-forge-36.1.0
Mod Version: 1.1.0
Java Version: 1.8.0

Issue Description

Spawner doesn't break if it spawns non-living entity like fireworks

Reproduce Steps

Place a spawner and set its SpawnData/SpawnPotentials to firework entity.

Additional Information

I think it could be because of these entities are not living entity.

LTCatt commented 3 years ago

This issue affects when dungeons arise mod. https://www.curseforge.com/minecraft/mc-mods/when-dungeons-arise The mob spawners generated in this mod actually spawns a firework, and the monster rides on the firework. So these spawners won't be destroyed.

LTCatt commented 3 years ago

Could you tell me this problem will be fixed soon or not? My modpack is about to be released, but because of this issue, players can farm monsters, which breaks the balance... I'm waiting for it to be fixed so long...

Mrbysco commented 3 years ago

I'm still looking into it. The event I rely on only fires for entities that extend MobEntity. Which the firework obviously doesn't. So I have to figure out another way

Mrbysco / AgeingSpawners