Mrbysco / OreBerries-Replanted

Ores that grow on Berry Bushes
https://www.curseforge.com/minecraft/mc-mods/oreberries-replanted
MIT License
5 stars 2 forks source link

[Bug]: Add support for thermal redstone furnace (every type gives iron nugget) #10

Open oskarbukovsky opened 1 month ago

oskarbukovsky commented 1 month ago

General Info

Forge version

47.3.1

Minecraft version

1.20.1

Mod version

0.5.2

Java version

17.0.8 64bit

Issue Description

Every Oreberry smelted in redstone furnace gives iron nugget Example

Additional Information

thermal_expansion-1.20.1-11.0.1.29.jar

Mrbysco commented 1 month ago

There's not much I can do since last I checked Thermal directly uses the result itemstack in their recipe instead of calling getResultItem which would give the proper smelted item since OreBerries smelting recipes use tags as the output

oskarbukovsky commented 1 month ago

Well i now hate thermal :D maybe ask if they'll add overloaded call with getResultItem

Not so pleasant way that i last 1/4h tried worked, cctweaker, but considering the work and it is probably not the best they didnt support cctweaker on newer versions like they do made me go crazy

<recipetype:thermal:furnace>.addJsonRecipe("fix-oreberry-05", {
  "type": "thermal:furnace",
  "ingredient": {
    "item": "oreberriesreplanted:copper_oreberry",
    "count": 1
  },
  "result": {
    "item": "thermal:copper_nugget"
  },
  "experience": 0.3,
  "energy_mod": 2.0
}
);

image

Mabye add support like that and add lookup to almost unified if user have some preferred mod ingots?

Mrbysco commented 1 month ago

🤷‍♂️ It's because of how Thermal converts vanilla smelting recipes to their own smelting recipe type