[Suggestion]: Compatibility with "The Salt"

[katubug]

General Info

• [X] I would like to propose new content
• [X] I would like to propose changes
• [ ] I would like to propose another thing

Suggestion Description

Hi! I'm a small-time modpack maker who is hoping to use your mod in my pack, and I was wondering if you would consider adding compatibility with the mod "The Salt"? Unsure if this is considered "changes" or "new content" so I checked both.

What I want is to have Salted foods not spoil (or spoil more slowly). But since your system is defined via tag, and Salt's salting system is defined via NBT, I don't see a way that I can make compatibility via KubeJS. I would be more than happy to donate a couple of bucks to both of y'all if this change could be possible!

Thanks so much for your time!

I've also asked the mod author of The Salt here: https://github.com/mortuusars/Salt/issues/21

[mortuusars]

@Mrbysco Hey, Salt dev here. I could implement the support from my side, but that would possibly require mixing in into your classes. I think it would be much easier to implement on the Spoiled side, since that would require just the compoundTag.contains("Salted") check. And maybe isModLoaded("Salt") to be extra sure. No dependencies on my mod, etc. Please let me know how you want this to be implemented, and if I should make any changes from my side. (or I can try making a PR to this repo)

[katubug]

I wanted to add a small note, in that this actually works - a little bit - out of the box. It seems, from my limited testing, that if you salt food immediately on obtaining it, then it won't spoil. If you wait for it to get the Spoiled data, however, it's a crapshoot whether it rots or not.

[katubug]

@Mrbysco Sorry to bother, is this something you'd consider? I'm hoping to release my modpack in time for Halloween, so I'd just like to know if I can expect this to happen, or if I need to adjust my plans. Thanks!

[Mrbysco]

Which Minecraft version?

[katubug]

1.20.1 would be my preference! Also hi! :D

[Mrbysco]

Done. A new build is being generated and uploaded

[katubug]

Thank you so much!

On Wed, Sep 4, 2024, 3:06 PM Mrbysco @.***> wrote:

Closed #54 https://github.com/Mrbysco/Spoiled/issues/54 as completed.

— Reply to this email directly, view it on GitHub https://github.com/Mrbysco/Spoiled/issues/54#event-14136549677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7XE5XMOQBPFS5HHXTO363ZU5R4LAVCNFSM6AAAAABMS7GRIKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGEZTMNJUHE3DONY . You are receiving this because you authored the thread.Message ID: @.***>

[Mrbysco]

The compat is behind a config option that defaults to false :) (In case you're trying to figure out how to enable the compat)

[katubug]

I found it, thank you so much!

On Thu, Sep 5, 2024, 2:37 AM Mrbysco @.***> wrote:

The compat is behind a config option that defaults to false :) (In case you're trying to figure out how to enable the compat)

— Reply to this email directly, view it on GitHub https://github.com/Mrbysco/Spoiled/issues/54#issuecomment-2330821942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7XE5VQRWGJZQ3DEK3VAUTZVAC5FAVCNFSM6AAAAABMS7GRIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQHAZDCOJUGI . You are receiving this because you authored the thread.Message ID: @.***>