search

Mrbysco / StructureCompass

Adds a compass for each Minecraft structure
https://www.curseforge.com/minecraft/mc-mods/structure-compass
MIT License
2 stars 6 forks source link

[Bug]: Game Breaks If Structure Search Fails #16

Open SansyTDST opened 1 year ago

SansyTDST commented 1 year ago

General Info

Forge version

47.2.0

Minecraft version

1.20.1

Mod version

2.0.5

Java version

Java 8 update 381

Issue Description

Im currently searching for an Ocean Monument, which i have allowed the compass to search for despite not being near one by allowing it in the config, but i kept the search distance at 10000. I try looking for the Monument, it starts search, i wait for a while and check the tooltip, not found. Now, after it cant be found, i cant right click anything. I cant switch to another structure, i cant eat, drink, use items and dropped items arent dropped. it destroys the game to the point that trying to save and quit doesnt work and you have to force close.

Additional Information

No response

Mrbysco commented 1 year ago

Can you use the locate command? Because the compass uses the exact same code so if the structure compass locks your game so should the locate command

SansyTDST commented 1 year ago

Hey, thanks for the quick response, I used the /locate command after giving up on finding what I needed legitimately and discovered that I installed Better Monuments and so the locate command was a dead end when using the minecraft one. However, I'm still confused as to why the compass completely breaks my game when it can't find a structure. I haven't had this issue otherwise, since it's always found a structure. Maybe it being a dead end command was messing with it, but I have no clue. Sorry for pinning it on this mod immediately when it's a conflict between this and another, I just assumed it was an issue with this mod because it only happened when using the compass

On Mon, 9 Oct 2023, 12:30 am Mrbysco, @.***> wrote:

Can you use the locate command? Because the compass uses the exact same code so if the structure compass locks your game so should the locate command

— Reply to this email directly, view it on GitHub https://github.com/Mrbysco/StructureCompass/issues/16#issuecomment-1752004264, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCGUH7PUYZ3APP4JFQP7P3LX6KFGVAVCNFSM6AAAAAA5XMSVQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGAYDIMRWGQ . You are receiving this because you authored the thread.Message ID: @.***>

Mrbysco commented 1 year ago

Any logs? (Make sure to remove the access token if you were to upload logs!)

SansyTDST commented 1 year ago

No logs, the game doesn't crash. The game plays, it just loses all function. I can move and jump but any breaking blocks, placing blocks or any player interaction with the world or items fail. Also, might be good to note that upon trying to save and quit, it says saving world forever. I waited half an hour, when it usually only takes 30 seconds, up to a minute if I'm starting to get frequent lag spikes. I eventually had to kill process. The game just loses its function, but stays open.

On Mon, 9 Oct 2023, 3:06 am Mrbysco, @.***> wrote:

Any logs? (Make sure to remove the access token if you were to upload logs!)

— Reply to this email directly, view it on GitHub https://github.com/Mrbysco/StructureCompass/issues/16#issuecomment-1752037022, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCGUH7IVKCMXMG5CBFM7OJTX6KXORAVCNFSM6AAAAAA5XMSVQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGAZTOMBSGI . You are receiving this because you authored the thread.Message ID: @.***>

Mrbysco commented 1 year ago

Then I have no clue, it shouldn't be able to lock your world up...

SansyTDST commented 1 year ago

Well, like I said, could just be because of the dead end command. Interestingly enough, when using the /locate command on it, the message it sends back isn't a normal not found error, it's a custom message from the better monuments mod telling me the right command. You said the compass does a /locate, maybe the problem isn't that it can't find it, the compass is running the command and is getting that message in return instead of the not found error, maybe that's where the problem is. That's the only other thing it could be, since like you said, it's the /locate command, which works as intended.

On Mon, 9 Oct 2023, 3:31 am Mrbysco, @.***> wrote:

Then I have no clue, it shouldn't be able to lock your world up...

— Reply to this email directly, view it on GitHub https://github.com/Mrbysco/StructureCompass/issues/16#issuecomment-1752042458, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCGUH7LPUYEFX2AXX65GD2LX6K2LNAVCNFSM6AAAAAA5XMSVQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGA2DENBVHA . You are receiving this because you authored the thread.Message ID: @.***>

Mrbysco commented 1 year ago

Might be some incompat with that Better Monuments mod if it's asking you to use their command. They probably have custom locating code. Structure Compass calls the locating code the regular locate command uses

SansyTDST commented 1 year ago

Only custom part about the monuments locate is the category. The compass does /locate structure minecraft:monument, but the mod removes that, so the structure can't be found and then the error message is replaced with the message. The monuments command is /locate structure bettermonuments:monument. I did also try using the compass to locate the monument with the correct category, and it worked flawlessly. It's just trying to look for a minecraft monument that doesn't exist breaks everything.

On Mon, 9 Oct 2023, 3:47 am Mrbysco, @.***> wrote:

Might be some incompat with that Better Monuments mod if it's asking you to use their command. They probably have custom locating code. Structure Compass calls the locating code the regular locate command uses

— Reply to this email directly, view it on GitHub https://github.com/Mrbysco/StructureCompass/issues/16#issuecomment-1752045692, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCGUH7OXB2ZRP25HQI54WX3X6K4IFAVCNFSM6AAAAAA5XMSVQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGA2DKNRZGI . You are receiving this because you authored the thread.Message ID: @.***>

MrLoLf commented 10 months ago

I've got some logs, that have this crash, probably in them. I used ATM 9 on 0.2.28 2023-12-10-3.log it at least has an error thrown of it. It's located at the end of the log.

Mrbysco commented 10 months ago

A new version of Structure Compass is being uploaded that adds some extra null checks that I apparently missed

funnycubeguy commented 7 months ago

Same this has been an issue forever. This mod handles structures terribly and will cause an entire server to crash like if you search for "minecraft:desert_pyramid" and it doesn't exist. It hard locks the server with no error log nothing just a thread dump after some time.

Mrbysco commented 7 months ago

A new version will be up shortly with a config option that makes structure locating asynchronous, please enable it and tell me if it fixes the problem

Artikae commented 6 months ago

I've

Can you use the locate command? Because the compass uses the exact same code so if the structure compass locks your game so should the locate command

I've run into this issue as well. /locate also hangs the server for me.