Mrbysco / Unhealthy-Dying

Reducing your maximum health any time you die.
https://www.curseforge.com/minecraft/mc-mods/unhealthy-dying
MIT License
3 stars 2 forks source link

[Bug]: Health will no longer regen back to default if other mod increases the health #21

Open TqLxQuanZ opened 11 months ago

TqLxQuanZ commented 11 months ago

General Info

Forge version

40.2.4

Minecraft version

1.18.2

Mod version

2.1.4

Java version

Java 17

Issue Description

Whenever the player dies a couple of times, then try to give the player effect "minecraft:health_boost" and make it exceed the default 20 values, and then whenever killing the specified mobs, it won't regen back at all due to the max health is boosted by the effect.

Expected behaviour what I imagine is: It will still regen back to the 20 default value, + the health boost effect still remains.

This also applies to the other mod that gives extra health boost, currently unhealthy dying just check the overall total max health from the player instead of its "default vanilla max health"

Additional Information

No response

Mrbysco commented 11 months ago

I've tried to stay compatible with other mods that adjust health in the past but it caused more issues than it helped so there's not really that much I can think of to help fix the issue