WIP dark mode - Githubissues

Mridul2820 / git-o-get

Git O Get - Github Profile Stats, Language Graph, Social Card, Contribution Graph, Repository Stats, Graphs and more

https://git-o-get.mridul.tech

MIT License

13 stars 16 forks source link

WIP dark mode #10

Closed NotAShelf closed 2 years ago

NotAShelf commented 2 years ago

i usually don't work with tailwind, attempting to add darkmode via tailwind css and a small button to toggle will work on it further soon, feel free to reimplement things to your liking as my ways might be viewed as crude

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @Mridul2820 on Vercel.

@Mridul2820 first needs to authorize it.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mridul28/git-to-get/2VYmD8ktwpAZkxqfTZPAgV6PVKGP
✅ Preview: https://git-to-get-git-fork-notashelf-main-mridul28.vercel.app

Mridul2820 commented 2 years ago

Hey, @NotAShelf thanks for your contribution. It's great that you have tried to add a new feature. As I can see in the Preview the dark mode is not affecting the site properly..

The text is not in right color in dark mode
It's not affecting the footer and navbar properly
Dark mode button is not available on the user detail page

If you can fix these few things it would be great. Thanks

NotAShelf commented 2 years ago

Hello! I'm aware of the problems with the dark mode, which is why I left the PR as a draft. I will check back on it as soon as I can and hopefully eradicate all issues next time I commit to my fork.

Mridul2820 commented 2 years ago

Great, Thanks