Update caesar-cipher.py

Mrinank-Bhowmick / python-beginner-projects

Explore a collection of beginner-friendly Python projects that can be completed with minimal code. Perfect for learning the basics and improving your coding skills.

https://github.com/Mrinank-Bhowmick/python-beginner-projects/wiki

MIT License

1.21k stars 664 forks source link

Update caesar-cipher.py #675

Closed hiarijit closed 11 months ago

hiarijit commented 11 months ago

Redundancy RESOLVED !!

Changes in both the encrypt and decrypt functions.

Reason for the changes :

The code for comparing value of new_shift greater than 25 is redundant.
This is because mod 26 of new_shift is already being computed in the previous line, making the range of new-shift between 0 and 25 inclusive.
So the if statements are never executed.

Therefore, these two if statements have been removed.

The working and compatibility of this code is not affected in any way due to these changes.

github-actions[bot] commented 11 months ago

Greetings! This is an automated message from GitHub Actions. :robot: Your pull request has been received and is awaiting for a review by the repository owner or a maintainer. This may take some time, so please be patient. While you wait, you can continue to work on other issues or pull requests, or explore the project further. Or you can simply relax and enjoy your day. Thank you for your contribution to this project! You are awesome! :star:

Mrinank-Bhowmick commented 11 months ago

Thanks for the changes 👍