Please depend on openid4java-consumer and not openid4java !

[GoogleCodeExporter]

Hi guys,

I do not understand why socialauth-core depends on openid4java excluding all 
but openid4java-consumer ? What is the advantage to do so ? It could cause new 
useless deps to be added if openid4java package evolved. It breaks any system 
that do not properly support maven exclusion (my issue).
Why not simply depends on openid4java-consumer ?

Denis

Original issue reported on code.google.com by denis.ge...@softec.lu on 7 Sep 2012 at 9:30

[GoogleCodeExporter]

Except consumer, we are using other classes from openid4java.jar. That's why we 
need this.

Regards
Tarun

Original comment by tarun.na...@3pillarglobal.com on 15 Oct 2012 at 11:10

• Changed state: Done

[GoogleCodeExporter]

I do not get your point since there absolutely no classes in 
openid4java-0.9.5.jar ! This is the poor usage by open4java of the jar 
packaging for there master pom that cause an empty jar to be generated. 
Moreover, since they put dependencies on their sample in that pom, it cause 
many unwanted dependencies to be added uselessly.
Depending on openid4java artifacts cause the following artifacts as 
dependencies:
openid4java-consumer
openid4java-server
openid4java-server-JdbcServerAssociationStore
openid4java-consumer-SampleConsumer
openid4java-server-SampleServer

I doubt you are using any class of any jar except the consumer one. So, why not 
simply depend on it ?

Original comment by denis.ge...@softec.lu on 15 Oct 2012 at 11:54

[GoogleCodeExporter]

Ok,

I got your point. But if you look into pom.xml of socialauth we are using the 
same whatever you are saying.

<dependency>
            <groupId>org.openid4java</groupId>
            <artifactId>openid4java</artifactId>
            <version>0.9.5</version>
            <exclusions>
                <exclusion>
                    <groupId>org.openid4java</groupId>
                    <artifactId>openid4java-server</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.openid4java</groupId>
                    <artifactId>openid4java-server-JdbcServerAssociationStore</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.openid4java</groupId>
                    <artifactId>openid4java-consumer-SampleConsumer</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.openid4java</groupId>
                    <artifactId>openid4java-server-SampleServer</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

We have written exclusion. So instead of this you can also write

<dependency>
            <groupId>org.openid4java</groupId>
            <artifactId>openid4java-consumer</artifactId>
            <version>0.9.5</version>
</dependency>

And main files are in openid4java-nodeps-0.9.5.jar if you look into the 
repository.

Regards
Tarun

Original comment by tarun.na...@3pillarglobal.com on 26 Oct 2012 at 12:44

[GoogleCodeExporter]

This exactly what I am asking for, change your deps to simply say

<dependency>
            <groupId>org.openid4java</groupId>
            <artifactId>openid4java-consumer</artifactId>
            <version>0.9.5</version>
</dependency>

It would avoid me to have to republish your releases with a modified pom, 
simply to support systems that do not applies exclusions. It also simplify and 
clarify your pom.

Original comment by denis.ge...@softec.lu on 26 Oct 2012 at 12:49

[GoogleCodeExporter]

Ok, We will modified this in upcoming release.

Regards
Tarun

Original comment by tarun.na...@3pillarglobal.com on 29 Oct 2012 at 10:59

[GoogleCodeExporter]

Great, thanks !

Original comment by denis.ge...@softec.lu on 29 Oct 2012 at 11:25