Added portal powerup and optimized images

[rahulraman0108]

Hello, respected owners, collaborators, and contributors to this repository. I want to merge my few edits to this repository, I optimized the two images with the help of IMG bot and added a portal powerup.

[MattZ45986]

@I-Am-The-Great, I like the idea, and as I was looking through the code, everything looks clean. However, the random-position finder works in a way that portals can spawn where players fall through the map in probably undesirable ways (as demonstrated by poor Larry, as Zeus looks on in horror). I would just modify some of the position-finding code to avoid this problem. Other than that, it is a power-up that has the potential to make many mods very interesting. Unless anyone else has issues, I would be willing to accept it once the modifications are made.

[rahulraman0108]

Hi, @MattZ45986 thanks for taking interest and participating in this PR. I am glad that you like my contribution, and the image is funny and it made me laugh at the situation :smile_cat: . Also in the image, I see the powerup shape is a sphere, which I modified in my latest commit changed the look of the portal powerup, so please see that look and say which one you like more.

[MattZ45986]

@I-Am-The-Great, I checked out the new look, and I do like the box shape better, but the texture might need some work. Aaand... there is another problem (depending on how you look at it). This time Larry was just minding his own business when all of a sudden he found himself stuck in a endless loop of falling through portals.

Another suggestion: make the portals space out.

Even if it's just to avoid this kind of situation, the portals should be some distance away from each other. More practically, it allows for easy transportation across the map, which is what they were probably designed for in the first place. It'll also give you a chance to put an original twist on @spdv123's code, which we always like to see. This time, Zeus pretends to not notice.

[rahulraman0108]

Well, this image is not funny, hmmm I will work on the code, change the texture and make portals opening away from one another.

[rahulraman0108]

Hey, @MattZ45986 now check, if the problem is out, and if you like the new texture.

[sudo-logic]

@I-Am-The-Great Impressive work with the Portals! My server has had this powerup since 9 months. I had fixed the bugs with players falling off the maps etc. Now all the portals open up inside the map bounds making sure that no one faces the problems that our little friend Larry is facing. I still have one bug which I'm too lazy to fix, sometimes the portal opens up close to the host portal causing the endless loop. It's not very disturbing as the portals only open up for 5 seconds after which Larry is able to move away peacefully. @I-Am-The-Great If you face any problem, I'll release my portal scripts.

[rahulraman0108]

Hi @Awesome-Logic the first server which I joined in BS was yours only, and I liked your server very much an even now I like it, I got inspired to be editing or modding in BS only after seeing your servers and your skills, I wanted to develop my skills and enhance the BombSquad game, you were my inspiration for all the time. And this portal powerup's idea I got from your servers only, and I wanted it to be open source for BS players and fans so I made some scripts and opened this pull request, so that every player can have the fun of portals even at local level. In fact, every BS projects which I do is to enhance the fun in playing the BombSquad game.

[sudo-logic]

Thanks a lot.😀

I'm thinking about making my server scripts open source for everyone.

It's been the most requested thing ever.

[MattZ45986]

Great work, @I-Am-The-Great. I think portals will make a nice addition to the mod manager. As soon as the screen message is removed, I consider the portal powerup to be @MattZ45986 approved. If there are any other projects you would like to share, by all means do!

[rahulraman0108]

Well I did changes but why it yet say changes required? :thinking:

[MattZ45986]

I just had to approve your changes. You are all set! Very nice work. I speak on behalf of the mod manager community when I say thank you for this fun (and might I add tried-and-tested) addition.

[rahulraman0108]

I just had to approve your changes. You are all set! Very nice work. I speak on behalf of the mod manager community when I say thank you for this fun (and might I add tried-and-tested) addition.

Oh, the changes need to be approved, well this was my first Pull Request to any repository which is not my so I did not know it, well thank you for approving my changes and accepting my pull request, I am happy :smiley: .

And I want to open a pull request for a minigame, originally by Froshlee, but I added some modifications, it the bsSoccer game, it in I disabled bombing, punching and grabbing from players and added backflip on jump press, well I am making it currently today I will complete it, and please say if this idea is worthy to be added to this repository.

[sritabh]

Isn't it like you're doing is copying others stuff and doing minor editing and taking whole credit for it? Is it good or bad?

[rahulraman0108]

Isn't it like you're doing is copying others stuff and doing minor editing and taking whole credit for it? Is it good or bad?

Lul :laughing: I am not taking credit of the snowyPowerup.py, and taking credit of making the portal powerup open source, in the Portal.py I have written that the original work of the random position finder is done by @spdv123 and I just did simple edits and about the bsSoccer game if approved then it will contain credits to Froshlee, and not to me, I would have just done simple edits in the script; so @SobyDamn your objection is totally wrong in my view.

I hope that you understand what I want to say.