search

Mrnt / OctoPrint-FlashForge

OctoPrint plugin to support closed source printers from FlashForge, PowerSpec, Dremel
GNU General Public License v3.0
86 stars 12 forks source link

Register in plugin repository? #24

Closed foosel closed 4 years ago

foosel commented 4 years ago

Hey @Mrnt! Great to see something like this to finally come together!

I'd love to see this getting registered on the official plugin repository at plugins.octoprint.org once you deem it stable enough. That way more people could find it easier. Or what do you think? :)

Mrnt commented 4 years ago

Thanks @foosel, I am flattered for the invite! I think it is a great idea. I have been trying to get enough traction so that I have a few "beta" testers to make sure it is basically solid before finding out how to get registered.

It seems fairly stable at this point - I guess one only hears when something is broken :). However, right now it only supports printing via SD and I didn't want to get a deluge of complaints about not being able to print line by line/layer by layer direct from OctoPrint (which I am currently trying to implement). Do you think it is useful enough as it is to add it to the official repository?

foosel commented 4 years ago

Do you think it is useful enough as it is to add it to the official repository?

I would say so, yes. I'd suggest to add a big fat disclaimer to the listing that it currently only supports SD upload and be prepared to close a bunch of tickets in that regard. Also make sure that it can update itself for when you push fixes and such. But other than that, considering that it's printing and one of those requests that have been going on for ages, I'd say it would be a good idea to register it ASAP and get more testers.

garyriet commented 4 years ago

I loaded your plugin on two octopie connected to two dreamers and its working pretty good! Thanks Gary

Mrnt commented 4 years ago

@foosel I think that I have the plugin ready to put in the repository but when I test the Github Pages locally following the setup here I am seeing an error:

Liquid Exception: undefined method `[]' for nil:NilClass in /_layouts/plugin_list.html
jekyll 3.8.5 | Error:  undefined method `[]' for nil:NilClass

Which seems to have been introduced in this commit.

foosel commented 4 years ago

Yep, that's my fault, I'm looking into it 😅

foosel commented 4 years ago

Fixed now, should be fine after a pull from origin.

Mrnt commented 4 years ago

Thanks! I just created a pull request that hopefully is ok :smile: