search

Mrthomas20121-Mods / Tinkers-Reforged

Add new Materials to Tinkers Construct.
https://www.curseforge.com/minecraft/mc-mods/tinkers-reforged
MIT License
4 stars 7 forks source link

Fluids broken, doubly so with PlusTiC, Tinkers' Evolution #25

Closed cha0sbuster closed 3 years ago

cha0sbuster commented 4 years ago

So while troubleshooting this issue over at Tinkers Evolution: phantamanta44/tinkers-evolution#58

I narrowed the issue down to this mod and revealed a few more. Get ready for a dump, half the week went into this.

  1. Fluids appear to be broken in the current version of Tinkers' Reforged. image

While they are visible in buckets, they're neither visible in the smeltery or in the world.

  1. Only the Gladius and Lightsword are visible in JEI, nothing else is visible or craftable. The rest aren't even listed in Materials and You, their pages replaced with errors: image

  2. Neither PlusTiC nor Tinkers' Evolution work properly with Reforged installed. PlusTiC's names (at least for fluids) for refined obsidian and glowstone are different from Reforged (Reforged separates with an underscore, PlusTiC does not, they're just "refinedobsidian" and "refinedglowstone") causing them to be registered as separate materials, breaking packs that use PlusTiC's fluids such as Enigmatica 2. Tinkers' Evolution's override function, while it does fix duplicate tools, does not fix fluids (as visible in the linked issue).

Aluminum's name is broken, but its texture works (as it's provided by vanilla TiC).

Mrthomas20121 commented 4 years ago

i'm aware of all of these problems.

cha0sbuster commented 4 years ago

Cool; hope details help with getting them fixed ^^

Let me know if you need anything else from me. Test instance is ready to go still.

Mrthomas20121 commented 3 years ago

fluids should be fixed now. i rewrote some part of the mod, that's why it took this long to fix(also having uni exams didn't help). i'm working on a better config rn because the current config doesn't please me. Tinkers' Evolution should work with tinkers reforged now.

cha0sbuster commented 3 years ago

Awesome!! I'll give it a go and see if it works now.

cha0sbuster commented 3 years ago

OH, it's not out quite yet. Not sure how to build a mod from source but if I figure it out before the update's pushed, I'll let you know :P

Mrthomas20121 commented 3 years ago

yeah it's not out yet, it should be out today. i'm only missing lang stuff