MscrmTools / MscrmTools.PolymorphicLookupCreator

GNU General Public License v3.0
6 stars 7 forks source link

Apply Changes doesn't display the busy dialog #11

Closed alex-mcla closed 7 months ago

alex-mcla commented 1 year ago

Selecting 'Apply Changes' doesn't display the yellow busy dialog with the spinner


MscrmTools commented 1 year ago

Hi @alex-mcla, according to the source code, no message is shown if no changes are detected. So just clicking on Apply Changes shouldn't do anything. Can you be more specific about your scenario?

alex-mcla commented 1 year ago

Hi @MscrmTools / Tanguy apologies. Reproduction steps are:

  1. Create a polymorphic lookup (yellow information messages / busy dialogs showing progress are displayed)
  2. Make a change to the created polymorphic lookup such as adding an additional entity, removing an entity, or changing the relationship info
  3. Select 'Apply Changes'
  4. Pop-up is displayed asking the user to confirm they wish to make the changes - see Update Relationships and Remove Relationships images
  5. Select 'Yes'
  6. I was expecting a yellow information message / busy dialog saying the changes are being applied - there is no indication that the system is taking action for several seconds

  7. A yellow information message / busy dialog is displayed very briefly saying 'Loading solutions'
  8. A yellow information message / busy dialog is displayed briefly saying 'Loading metadata' - see Loading metadata image
Update Relationship Remove Relationship Loading metadata

To confirm the behaviour I was expecting and is currently not there. When Apply Changes and Yes is selected, it would be great to have a yellow information message / busy dialog saying along the lines of 'Changes are being applied'

MscrmTools commented 1 year ago

Thank you.

I will try to reproduce

alex-mcla commented 1 year ago

Hi @MscrmTools a thought for you if haven't already completed this issue - would it be worth including the same solution selector as you use in the View Layout Replicator (or another favourite)? Please feel free to ignore this, or if you'd like me to raise under a separate Issue, please let me know.

MscrmTools commented 1 year ago

Yes, please create another issue and be more specific as I'm not sure to understand what you are talking about :)