Mshuu / SwitchDexIssues

15 stars 6 forks source link

Withdraws to Metamask Account always show 0 amount #49

Open jackrabbithanna opened 4 years ago

jackrabbithanna commented 4 years ago

I linked a Metamask account to the McAfeeDEX. I was able to deposit from this account to the McAfeeDEX account to make available some balance for trading.

When I try to withdraw from the DEX back to the account, from the Balance -> Withdraw menu, metamask popup to confirm appears, but the ether amount is always 0, no matter what I enter as the amount from the DEX withdraw popup.

I've tried different amounts underneath my total balance, to make sure there is enough ether for gas for the transfer, no matter what amount I enter, the metamask popup always shows 0 ether, but there is a gas charge.

jackrabbithanna commented 4 years ago

I think I misunderstood how withdraw from the DEX works. I was able to withdraw tokens from McAfeeDEX with MetaMask without issue. Learning here, sorry!

It's different from a "normal" token transfer between wallets, getting it out of the DEX and back to your wallet it token transfer transaction is actually an operation on the DEX smart contract that has a "transfer" function ....

Even for withdrawing ESH, the amount in metamask showed 0 ether, but the feature did work, tokens appeared in metamask after one block confirmation.

I think that this is more of a "nice to have" UI/UX thing and maybe MetaMask UI is out of the control of the DEX software. IDK if you can inform Metamask via API to make it more clear to people, but maybe I'm just too much of a DEX newbie. Anyway, maybe something to document for newbies for official release launch who are not used to decentralized exchanges.