search

Mtarnuhal / FrozenCookies

An automated Cookie Clicker tool.
27 stars 22 forks source link

fix autoGodzamokAction #58

Closed leno3s closed 3 years ago

leno3s commented 3 years ago

In the current implementation, autoGodzamokAction will not buy back unless autoBuy is enabled. However, if you enabled autoBuy, you will buying other buildings more than just buying back. This will not store cookies in Bank.

In some cases, you mayget more CpS if you buy Upgrades with storing cookies than if you buy buildings. In this situation, feels very inconvenient.

For that reason, I want to return the behavior of only buy back like before.

adavidw commented 3 years ago

Changing it that way would make it so that there's no option to not buy back. The previous (confusing) options included a mode where it would buy back and a mode where it wouldn't buy back. We tried to replicate that without having to have multiple modes by tying it to autoBuy.

autoBuy has blacklist modes that keep it from buying upgrades as well as a blacklist that keeps it from buying buildings. Does that not work for that scenario?

leno3s commented 3 years ago

I want to re-activate Godzamok's buff when it expired. just like before. That's why I wanted to make it automatic to buy back the buffs.

I'm sorry, I didn't understand the blacklist mode. However, when I don't buy back buildings in blacklist mode, I can't re-activate it because I don't buy back any buildings. So, I think we have to change the implementation.

Should I add an option for automatic buying back?

Mtarnuhal commented 3 years ago

We can't implement this because its breaks multiple safeguards that where put there in the first place. Also It breaks the intended functionality of autoGodzamok.
Readup on the intended purpose of autoGodzamok. https://github.com/Mtarnuhal/FrozenCookies/pull/45 If you can make it optional then I think we can add it back in.

Blacklist Mode "NO BUILDINGS" only prevents autoBuy for buying buildings autoGodzamok will buy the sold items back as it should.

leno3s commented 3 years ago

Blacklist Mode "NO BUILDINGS" only prevents autoBuy for buying buildings autoGodzamok will buy the sold items back as it should.

This is exactly what I was looking for. I'll use it.

I've implemented it experimentally, but if the the implementation doesn't work, please close it.