search

Mtarnuhal / FrozenCookies

An automated Cookie Clicker tool.
27 stars 22 forks source link

Golden Cookie spawn time estimate calculations dont reflect when the golden cookie will actually spawn, given certain GC frequency upgrades #73

Open mr-cats opened 3 years ago

mr-cats commented 3 years ago

The golden cookie estimate spawn timers suggest that Frozen Cookies is calculating the minimum GC spawn time to be about 2130 ticks, which is what the minimum spawn time would be if you only had the two double frequency upgrades in addition to one of the "5% more frequent" upgrades. If you have other late game means of improving GC Frequency, the estimate does not reflect it.

adavidw commented 3 years ago

I've seen this myself, but haven't dug into the code on that yet, so thanks.

I think there are two things to look at. One is the point you bring up about the minimum spawn time and the multipliers. Another is once the spawn time is determined to be able to correctly calculate the probabilities across the full spawn time. I've made a couple of changes regarding the probability prediction, but haven't got the modifier calculation all done. I'll poke at that some more.

mr-cats commented 3 years ago

If these calculations are using a value for minimum and maximum spawn time, I believe these can be taken directly from Game.shimmerTypes["golden"].minTime and Game.shimmerTypes["golden"].maxTime instead of inferred from upgrades, which has the benefit of including garden plant effects as well.

Somewhat related, if the frequency increase upgrades that are tracked by FC are purchased, it updates the estimate calculator immediately, whereas the game only updates the frequency upon the next GC click. I think this issue also would get solved by taking the times directly from the game.

RobertBuchananWMG commented 3 years ago

I can confirm the numbers on the display do not account for the garden.