search

Mtarnuhal / FrozenCookies

An automated Cookie Clicker tool.
27 stars 22 forks source link

efficiencyWeight is 1.0 #80

Open DanielNoord opened 3 years ago

DanielNoord commented 3 years ago

I saw in the code that currently efficiencyWeight is set to 1.0. This is in contrast to what is described in the README, which says that after testing it was found that 1.15 is more effective.

As maintainer of Cookie Monster I'm interested in the rationale behind changing it to 1.0 again (according to the git blame this was done over 4 years ago...). Has it turned out the efficiency weight was actually different?

Mtarnuhal commented 3 years ago

Can you link back to the where it was changed. at this point I have no clue why that was changed.

DanielNoord commented 3 years ago

https://github.com/Mtarnuhal/FrozenCookies/blame/3e32fafa19bdaa794a2a8313ba8a8301717c67e7/fc_main.js#L82 This is the relevant git blame, at line 82. You were not even the one to do it so I can imagine if you have no idea about the why.

It's just that I was reading up somewhere about how Frozen Cookies used to have a more effective measurement than Cookie Monster and I wanted to see if I could update it. But now it turns out it has been changed so I'm wondering if any improvement can stil be made.

Mtarnuhal commented 3 years ago

Yeah, it is prior to me taking over and maintaining the code. It's worth testing if efficiencyWeight is set to 1.15 is more effective.

DanielNoord commented 3 years ago

My bad, it is actually this commit: https://github.com/Mtarnuhal/FrozenCookies/commit/3775c0cb5fc317553e24c6d66c51694034597bc4

Looking at the changelog I see no reason why this was changed. According to the tests displayed in the README it should still be 1.15, although I'm wondering if the code of Cookie Monster changed between 2013 and now and might have changed whether the modifier still holds true. In any case, I don't quite understand the argument for the modifier. The modifier puts more weight on the cost of the building and will make you buy cheaper buildings. I don't immediately see how this would consistently outperform a function that calculate the payback time as Frozen Cookies and Cookie Monster currently do.