MtbEvolution / resR_Project

3 stars 0 forks source link

Unfixed pipeline: 1_MTBC_Annotation_mtbc_4411532.pl : hard-coded paths #5

Closed weiju closed 10 months ago

weiju commented 11 months ago

Hi, I just wanted to let you know that the script 1_MTBC_Annotation_mtbc_4411532.pl contains hardcoded paths

open F1, "</n/home07/edwin/script/translate/mtbc_translate/2_Tuberculist_new_20150307" or die $!; #open Tuberculist_new_20150307

...

open F2, "</n/home07/edwin/script/translate/mtbc_translate/3_genetic_codes" or die $!; #open genetic_code

...

open F3, "</n/home07/edwin/script/translate/mtbc_translate/4_mtbc_sequence.fasta" or die $!; #open genome.fasta

Since they refer to files within the project I was able to adjust the path, but I think it would be easier to keep the paths outside the Perl file.

Thank you !

MtbEvolution commented 10 months ago

Hi,

Just simply replace those with the directory paths of your own.

Qingyun

On Dec 15, 2023, at 15:22, Wei-ju Wu @.**@.>> wrote:

Hi, I just wanted to let you know that the script 1_MTBC_Annotation_mtbc_4411532.pl contains hardcoded paths

open F1, "</n/home07/edwin/script/translate/mtbc_translate/2_Tuberculist_new_20150307" or die $!; #open Tuberculist_new_20150307

...

open F2, "</n/home07/edwin/script/translate/mtbc_translate/3_genetic_codes" or die $!; #open genetic_code

...

open F3, "</n/home07/edwin/script/translate/mtbc_translate/4_mtbc_sequence.fasta" or die $!; #open genome.fasta

Since they refer to files within the project I was able to adjust the path, but I think it would be easier to keep the paths outside the Perl file.

Thank you !

— Reply to this email directly, view it on GitHubhttps://github.com/MtbEvolution/resR_Project/issues/5, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZVZDORPZGO3CEDDED6LDFTYJSWQ7AVCNFSM6AAAAABAW6KMKCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DIMZSGUZTENI. You are receiving this because you are subscribed to this thread.Message ID: @.***>