MtcLeo05 / QualityCrops

A mod that adds qualities to some crops and foods, inspired by Stardew Valley's qualities
Other
1 stars 1 forks source link

[Forge - 1.19.2]: Modded items in tags are not set to optional #5

Closed SiverDX closed 11 months ago

SiverDX commented 11 months ago
[18Oct2023 18:08:31.870] [Worker-ResourceReload-4/ERROR] [net.minecraft.tags.TagLoader/]: [Load My Fucking Tags] Couldn't load certain entries with the tag forge:gold/raw_fishes: qualitysdelight:cod_slice_gold (from QualityCrops-1.19.2-1.3.0.jar), qualitysdelight:salmon_slice_gold (from QualityCrops-1.19.2-1.3.0.jar)
[18Oct2023 18:08:31.877] [Worker-ResourceReload-4/ERROR] [net.minecraft.tags.TagLoader/]: [Load My Fucking Tags] Couldn't load certain entries with the tag forge:iron/cooked_fishes: qualitysdelight:cooked_cod_slice_iron (from QualityCrops-1.19.2-1.3.0.jar), qualitysdelight:cooked_salmon_slice_iron (from QualityCrops-1.19.2-1.3.0.jar)
[18Oct2023 18:08:31.881] [Worker-ResourceReload-4/ERROR] [net.minecraft.tags.TagLoader/]: [Load My Fucking Tags] Couldn't load certain entries with the tag forge:diamond/cooked_fishes: qualitysdelight:cooked_cod_slice_diamond (from QualityCrops-1.19.2-1.3.0.jar), qualitysdelight:cooked_salmon_slice_diamond (from QualityCrops-1.19.2-1.3.0.jar)
{
  "values": [
    "qualitysdelight:cod_slice_gold",
    "qualitysdelight:salmon_slice_gold"
  ]
}

should be (can also be done in datagen)

{
  "values": [
    { "id": "qualitysdelight:cod_slice_gold",, "required": false },
    { "id": "qualitysdelight:salmon_slice_gold", "required": false }
  ]
}

This will normally break those tags

Also what's the difference between /<rarity>/raw_fishes and /<rarity>/raw_fishes/raw_fishes? I think the second one is a mistake

SiverDX commented 11 months ago

Also it would be helpful if you could add your items to the generic forge tags, not just the custom quality variants (which by the way should be in your namespace, not the forge namespace)

SiverDX commented 11 months ago

In general the tags seem messy Why are some meats in raw_fishes?

MtcLeo05 commented 11 months ago

There were some errors while generating tags, that's why they're messy. For example the qualitysdelight items shouldn't be in the qualitycrops tags. Should be fixed next version