search

Mte90 / Contribute-to-opensource-the-right-way

Be a part of the open source world can be the 21 century skills that you deserve?
https://leanpub.com/contributetoopensource-therightway/
GNU General Public License v3.0
130 stars 6 forks source link

2020.1 Edition #17

Closed Mte90 closed 4 years ago

Mte90 commented 4 years ago

As title but is not yet ready, missing review.

Ryuno-Ki commented 4 years ago

@Mte90 Ah, so it's basically what I reviewed earlier?

Mte90 commented 4 years ago

Yes this pr include what you found but also other stuff

Mte90 commented 4 years ago

Thanks @Ryuno-Ki for the review but I didn't finish to add stuff in the book, I wanted just to start tracking them so i can more easily review. So for you I suggest to do it when is ready because I didn't check the grammar etc yet (as you saw 😅).

Ryuno-Ki commented 4 years ago

Sure. Ping me if you feel the need of another round of feedback :-)

Mte90 commented 4 years ago

I think that I am ready to release the new version but I will do a check of all those new changes before an official announcement for reviewing.

Mte90 commented 4 years ago

@Ryuno-Ki it is ready for the review :-)

Ryuno-Ki commented 4 years ago

I'm done looking at the remaining diffs.

Sorry for the delay, @Mte90!

Mte90 commented 4 years ago

Thanks for your time! I think that there are just 2 questions to close/discuss and the book is ready!

Ryuno-Ki commented 4 years ago

Hi Daniele!

So kind of GitHub to collapse all conversations. I hope, I spotted those questions. Do you plan to give a release party? :confetti_ball: :D

Mte90 commented 4 years ago

I don't think that I can do the party, but friday will be my 30 birthday so I think that can be a party anyway 😂