search

Mte90 / GlotDict

This extension for WordPress polyglots implements new features to improve the quality of translation/reviews!
https://translate.wordpress.org
GNU General Public License v2.0
55 stars 24 forks source link

Buttons in sidebar are glitchy - Wrong results shown #394

Closed NekoJonez closed 1 year ago

NekoJonez commented 2 years ago

I don't know if either a conflict with Transfill or WPGP tools is happening but... Or conflicts with some latest GlotPress updates...

But, I notice that when I click fuzzy, the color of the row doesn't change and sometimes when I reject a string... It shows as accepted!

I use Opera, the latest build at the time of writing.

NekoJonez commented 2 years ago

Note, while the colors don't change or change wrong... The right thing still happens.

webaxones commented 2 years ago

Hi @NekoJonez Can you do a little video capture for us to see what's going on please? Thanks :)

NekoJonez commented 2 years ago

As I don't have the right computer to have screenrecording on right now... I made a screenshot... So, this happened after clicking reject. You can see at the 2nd line it's not coloring red.

image

Yet when I refresh:

image

NekoJonez commented 2 years ago

After some further testing, it's WPTranslationFiller messing it up. When I disable that extension and refresh the page... GlotDict resumes normal operation. :) So, I'm going to close this ticket here since I think this isn't anything GlotDict related and open a ticket over at WPTransfill. If it's something GlotDict should do, I'll reopen this. I'm also going to ping Peter Smits on Slack about this.

NekoJonez commented 2 years ago

According to Peter... This might be something GlotDict should look at as well: https://github.com/vibgyj/WPTranslationFiller/issues/231

NekoJonez commented 2 years ago

That issue also has a vid of the behaviour

vlad-timotei commented 2 years ago

Looks like the solution has been found in the issue above to make WPTF compatible with GlotDict. :)

NekoJonez commented 1 year ago

https://github.com/vibgyj/WPTranslationFiller/issues/231 @vlad-timotei , could this possibly be re-opened? Since, I think adding the CSS for the edge case in GlotDict would help us quite a lot. I also posted an improved CSS code for the new state.

vlad-timotei commented 1 year ago

IMHO GlotDict shouldn't add code to be compatible with other extensions when those update. It is not sustainable. Its main purpose is to be compatible with GlotPress on w.org and as a main extension, other extensions should ensure compatibility with GlotDict.

I don't see why the css can't be added in wptf if it is only needed when wptf is present. 😁

NekoJonez commented 1 year ago

IMHO GlotDict shouldn't add code to be compatible with other extensions when those update. It is not sustainable. Its main purpose is to be compatible with GlotPress on w.org and as a main extension, other extensions should ensure compatibility with GlotDict.

I don't see why the css can't be added in wptf if it is only needed when wptf is present. 😁

Because the CSS in only WPTF doesn't fix the issue. And putting it in GlotDict & WPTF works. Oh well, then I'll just place it every time I guess :P

vlad-timotei commented 1 year ago

Because the CSS in only WPTF doesn't fix the issue.

I will take a look and see how it can be implemented in WPTF. I don't think GlotDict enforces any styles in ways that can't be overridden by WPTF