search

Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 81 forks source link

Art v3_15_00 preparation #1257

Closed kutschke closed 4 months ago

kutschke commented 5 months ago

Make changes to that are required for art suite v3_15_00 that upgrades root to v6_30_06. The submitted code works with both the new art suite and the with the current art suite v3_14_03. I checked that 2000 events of ceSimReco produced identical results.

In all cases the problem was that fhicl code was exposed to dictionary makers because of people having includes that were either unneeded or were in the .hh file rather than the .cc file, where they belonged. I don't understand the details of what in fhicl is causing the problem but there is no reason for fhicl code to be exposed to dictionary makers.

This is something that likely would have been fixed by IWYU so that is back on my list as a priority.

There will be an accompanying PR in REve.

There were no build-time issues with TrackerAlignment, TrkAna and Tutorial.

FNALbuild commented 5 months ago

Hi @kutschke, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

:hourglass: The following tests have been triggered for 9806dcab0df5db3b2f543d738cc17cc071c8bac7: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 5 months ago

:sunny: The build tests passed at 9806dcab0df5db3b2f543d738cc17cc071c8bac7.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 9806dcab0df5db3b2f543d738cc17cc071c8bac7 at 07a76f5fcecbc4e3ef9c6edf73c17dd777164d46
build (prof) :white_check_mark: Log file. Build time: 10 min 58 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :large_orange_diamond: TODO (1) FIXME (1) in 12 files
clang-tidy :large_orange_diamond: 0 errors 2444 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 9806dcab0df5db3b2f543d738cc17cc071c8bac7 after being merged into the base branch at 07a76f5fcecbc4e3ef9c6edf73c17dd777164d46.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

FNALbuild commented 5 months ago

:memo: The HEAD of main has changed to f6fe4b179609d05e47360389021305d824194522. Tests are now out of date.

kutschke commented 5 months ago

For the record, here is Kyle's explanation for why the new fhiclcpp caused problems.

with art 3.15, we are using C++20 concepts to constrain the types of arguments allowed for function templates. ROOT's genreflex and rootcling functionalities do not yet understand C++20 concepts; hence the failures. I'm glad you were able to get around the issue–we've tried to avoid using C++20 concepts in places where dictionaries will be generated...but that does require some reworking of code.

The bottom line remains that we should never have been exposing fhicl to genreflex.

kutschke commented 4 months ago

First test of CI after Jenkins migration:

@FNALbuild run build test

FNALbuild commented 4 months ago

:hourglass: The following tests have been triggered for 9806dcab0df5db3b2f543d738cc17cc071c8bac7: build (Build queue is empty)

FNALbuild commented 4 months ago

:sunny: The build tests passed at 9806dcab0df5db3b2f543d738cc17cc071c8bac7.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 9806dcab0df5db3b2f543d738cc17cc071c8bac7 at 575bf815aa5dcedceb828e01ef77514073178ea9
build (prof) :white_check_mark: Log file. Build time: 21 min 07 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :large_orange_diamond: TODO (1) FIXME (1) in 12 files
clang-tidy :large_orange_diamond: 0 errors 2444 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 9806dcab0df5db3b2f543d738cc17cc071c8bac7 after being merged into the base branch at 575bf815aa5dcedceb828e01ef77514073178ea9.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.