search

Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 81 forks source link

Use charge from KalSeed pdg code #1258

Closed brownd1978 closed 5 months ago

brownd1978 commented 5 months ago

This is an alternate and more robust (definitive) fix to the problem addressed in PR 1255

FNALbuild commented 5 months ago

Hi @brownd1978, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

:hourglass: The following tests have been triggered for b8421cc3ee764b0740db9de7af0c6170a6c88012: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 5 months ago

:sunny: The build tests passed at b8421cc3ee764b0740db9de7af0c6170a6c88012.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged b8421cc3ee764b0740db9de7af0c6170a6c88012 at 07a76f5fcecbc4e3ef9c6edf73c17dd777164d46
build (prof) :white_check_mark: Log file. Build time: 21 min 21 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :large_orange_diamond: TODO (1) FIXME (0) in 1 files
clang-tidy :large_orange_diamond: 0 errors 241 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at b8421cc3ee764b0740db9de7af0c6170a6c88012 after being merged into the base branch at 07a76f5fcecbc4e3ef9c6edf73c17dd777164d46.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke commented 5 months ago

I would like to hear the answers to Ray's questions but I want to merge this now for tonight's validation.