search

Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 81 forks source link

added DB to the eventdisplay fcl files #1260

Closed ehrlich-uva closed 5 months ago

ehrlich-uva commented 5 months ago

The event display requires the values of the CRV pedestals to display reconstructed CRV waveforms. These values are in the database.

FNALbuild commented 5 months ago

Hi @ehrlich-uva, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

:hourglass: The following tests have been triggered for 6ce5435b39c2bf1d0a7522c857b711548aca9058: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 5 months ago

:sunny: The build tests passed at 6ce5435b39c2bf1d0a7522c857b711548aca9058.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 6ce5435b39c2bf1d0a7522c857b711548aca9058 at 7eeafee28e3390039ea022d841c363d88ad7782e
build (prof) :white_check_mark: Log file. Build time: 11 min 06 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 0 files
clang-tidy :white_check_mark: 0 errors 0 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 6ce5435b39c2bf1d0a7522c857b711548aca9058 after being merged into the base branch at 7eeafee28e3390039ea022d841c363d88ad7782e.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke commented 5 months ago

@ehrlich-uva Dave put in a PR that creates Offline/DbService/fcl/NominalDatabase.fcl . Please update your PR to remove this file and #include the new file instead. Once Dave approves, I will merge.

FNALbuild commented 5 months ago

:memo: The HEAD of main has changed to a15e04e4afd4bb7bd4054dad22875e876e4741fd. Tests are now out of date.

kutschke commented 5 months ago

THanks Ralf. I won't run the PR since this change has no coverage in the PR.

ehrlich-uva commented 5 months ago

I had to include the NominalDatabase.fcl at the end of the fcl files. Otherwise the settings would have been overwritten by DbEmpty (via @table::Services.Core), which is defined in DbService/fcl/prolog.fcl.

kutschke commented 5 months ago

I had to include the NominalDatabase.fcl at the end of the fcl files. Otherwise the settings would have been overwritten by DbEmpty (via @table::Services.Core), which is defined in DbService/fcl/prolog.fcl.

Yes. That's right.