search

Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 81 forks source link

start ad-hoc table feature #1264

Closed rlcee closed 4 months ago

rlcee commented 4 months ago

Ad-hoc tables have arbitrary structure and the user can just insert and read rows as they chose. They can't be accessed though a conditions set and will not be available in production. The tables are still defined in DbTables code so they can be manipulated by existing tools. The immediate use case is to record which CID in an archive table corresponds to which CID in a reco table. There is an example in the dev database:

build01 db > dbTool print-adhoc --database mu2e_conditions_dev --full --pretty --name TstAdhoc1
TABLE TstAdhoc1
# exint   exfloat           exstring   create_user                        create_time   
      0,      1.3,     first comment,          rlc,  2024-05-14 19:15:37.715581-05:00
     21,      2.3,   another comment,          rlc,  2024-05-14 19:15:37.715581-05:00

This should have no effect on any validation

FNALbuild commented 4 months ago

Hi @rlcee, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

:hourglass: The following tests have been triggered for 32ff8eb21c873d7d44defb4f6d9beb2403e92675: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 4 months ago

:sunny: The build tests passed at 32ff8eb21c873d7d44defb4f6d9beb2403e92675.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 32ff8eb21c873d7d44defb4f6d9beb2403e92675 at 275576119455116e27dedf4e818c1eefdc6f9be2
build (prof) :white_check_mark: Log file. Build time: 11 min 29 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 5 files
clang-tidy :large_orange_diamond: 0 errors 360 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 32ff8eb21c873d7d44defb4f6d9beb2403e92675 after being merged into the base branch at 275576119455116e27dedf4e818c1eefdc6f9be2.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

rlcee commented 4 months ago

Is this anyone who can meaningfully review this.

Richie might have some thoughts to add. The code is mostly cut-and-paste. Ii would be good to discuss in the calibration meeting, but no need to wait for that - as-is, there is the example in dev and nothing in prd, so we can still easily change.

kutschke commented 4 months ago

Richie might have some thoughts to add. The code is mostly cut-and-paste. Ii would be good to discuss in the calibration meeting, but no need to wait for that - as-is, there is the example in dev and nothing in prd, so we can still easily change.

@bonventre I will merge Ray's PR now. I am sending this as an FYI that it's something you might want to follow. Of course all comments are welcome.